5deb7c2fb0
Eliminates a bajillion nil checks and footguns (except in tests, which bypass exported APIs, but that is expected) Most recent #207 Logging can still be disabled via zap.NewNop(), if necessary. (But disabling logging in CertMagic is a really bad idea.)
109 lines
4.3 KiB
Go
109 lines
4.3 KiB
Go
// Copyright 2015 Matthew Holt
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
package certmagic
|
|
|
|
import (
|
|
"crypto/tls"
|
|
"crypto/x509"
|
|
"net"
|
|
"testing"
|
|
)
|
|
|
|
func TestGetCertificate(t *testing.T) {
|
|
c := &Cache{
|
|
cache: make(map[string]Certificate),
|
|
cacheIndex: make(map[string][]string),
|
|
logger: defaultTestLogger,
|
|
}
|
|
cfg := &Config{Logger: defaultTestLogger, certCache: c}
|
|
|
|
// create a test connection for conn.LocalAddr()
|
|
l, _ := net.Listen("tcp", "127.0.0.1:0")
|
|
defer l.Close()
|
|
conn, _ := net.Dial("tcp", l.Addr().String())
|
|
if conn == nil {
|
|
t.Errorf("failed to create a test connection")
|
|
}
|
|
defer conn.Close()
|
|
|
|
hello := &tls.ClientHelloInfo{ServerName: "example.com", Conn: conn}
|
|
helloSub := &tls.ClientHelloInfo{ServerName: "sub.example.com", Conn: conn}
|
|
helloNoSNI := &tls.ClientHelloInfo{Conn: conn}
|
|
helloNoMatch := &tls.ClientHelloInfo{ServerName: "nomatch", Conn: conn}
|
|
|
|
// When cache is empty
|
|
if cert, err := cfg.GetCertificate(hello); err == nil {
|
|
t.Errorf("GetCertificate should return error when cache is empty, got: %v", cert)
|
|
}
|
|
if cert, err := cfg.GetCertificate(helloNoSNI); err == nil {
|
|
t.Errorf("GetCertificate should return error when cache is empty even if server name is blank, got: %v", cert)
|
|
}
|
|
|
|
// When cache has one certificate in it
|
|
firstCert := Certificate{Names: []string{"example.com"}, Certificate: tls.Certificate{Leaf: &x509.Certificate{DNSNames: []string{"example.com"}}}}
|
|
c.cacheCertificate(firstCert)
|
|
if cert, err := cfg.GetCertificate(hello); err != nil {
|
|
t.Errorf("Got an error but shouldn't have, when cert exists in cache: %v", err)
|
|
} else if cert.Leaf.DNSNames[0] != "example.com" {
|
|
t.Errorf("Got wrong certificate with exact match; expected 'example.com', got: %v", cert)
|
|
}
|
|
if _, err := cfg.GetCertificate(helloNoSNI); err == nil {
|
|
t.Errorf("Did not get an error with no SNI and no DefaultServerName, but should have: %v", err)
|
|
}
|
|
|
|
// When retrieving wildcard certificate
|
|
wildcardCert := Certificate{
|
|
Names: []string{"*.example.com"},
|
|
Certificate: tls.Certificate{Leaf: &x509.Certificate{DNSNames: []string{"*.example.com"}}},
|
|
hash: "(don't overwrite the first one)",
|
|
}
|
|
c.cacheCertificate(wildcardCert)
|
|
if cert, err := cfg.GetCertificate(helloSub); err != nil {
|
|
t.Errorf("Didn't get wildcard cert, got: cert=%v, err=%v ", cert, err)
|
|
} else if cert.Leaf.DNSNames[0] != "*.example.com" {
|
|
t.Errorf("Got wrong certificate, expected wildcard: %v", cert)
|
|
}
|
|
|
|
// When cache is NOT empty but there's no SNI
|
|
if _, err := cfg.GetCertificate(helloNoSNI); err == nil {
|
|
t.Errorf("Expected TLS allert when no SNI and no DefaultServerName, but got: %v", err)
|
|
}
|
|
|
|
// When no certificate matches, raise an alert
|
|
if _, err := cfg.GetCertificate(helloNoMatch); err == nil {
|
|
t.Errorf("Expected an error when no certificate matched the SNI, got: %v", err)
|
|
}
|
|
|
|
// When default SNI is set and SNI is missing, retrieve default cert
|
|
cfg.DefaultServerName = "example.com"
|
|
if cert, err := cfg.GetCertificate(helloNoSNI); err != nil {
|
|
t.Errorf("Got an error with no SNI with DefaultServerName, but shouldn't have: %v", err)
|
|
} else if cert == nil || cert.Leaf.DNSNames[0] != "example.com" {
|
|
t.Errorf("Expected default cert, got: %v", cert)
|
|
}
|
|
|
|
// When default SNI is set and SNI is missing but IP address matches, retrieve IP cert
|
|
ipCert := Certificate{
|
|
Names: []string{"127.0.0.1"},
|
|
Certificate: tls.Certificate{Leaf: &x509.Certificate{IPAddresses: []net.IP{net.ParseIP("127.0.0.1")}}},
|
|
hash: "(don't overwrite the first or second one)",
|
|
}
|
|
c.cacheCertificate(ipCert)
|
|
if cert, err := cfg.GetCertificate(helloNoSNI); err != nil {
|
|
t.Errorf("Got an error with no SNI but matching IP, but shouldn't have: %v", err)
|
|
} else if cert == nil || len(cert.Leaf.IPAddresses) == 0 {
|
|
t.Errorf("Expected IP cert, got: %v", cert)
|
|
}
|
|
}
|