zerossl: Make CNAME target absolute (fix #304)
This commit is contained in:
parent
1ff1ad8413
commit
16c9db1449
@ -51,7 +51,7 @@ func (iss *ACMEIssuer) newACMEClientWithAccount(ctx context.Context, useTestCA,
|
|||||||
}
|
}
|
||||||
|
|
||||||
// we try loading the account from storage before a potential
|
// we try loading the account from storage before a potential
|
||||||
// lock, and 0after obtaining the lock as well, to ensure we don't
|
// lock, and after obtaining the lock as well, to ensure we don't
|
||||||
// repeat work done by another instance or goroutine
|
// repeat work done by another instance or goroutine
|
||||||
getAccount := func() (acme.Account, error) {
|
getAccount := func() (acme.Account, error) {
|
||||||
// look up or create the ACME account
|
// look up or create the ACME account
|
||||||
|
@ -146,7 +146,7 @@ func (iss *ZeroSSLIssuer) Issue(ctx context.Context, csr *x509.CertificateReques
|
|||||||
// create the CNAME record(s)
|
// create the CNAME record(s)
|
||||||
records := make(map[string]zoneRecord, len(cert.Validation.OtherMethods))
|
records := make(map[string]zoneRecord, len(cert.Validation.OtherMethods))
|
||||||
for name, verifyInfo := range cert.Validation.OtherMethods {
|
for name, verifyInfo := range cert.Validation.OtherMethods {
|
||||||
zr, err := iss.CNAMEValidation.createRecord(ctx, verifyInfo.CnameValidationP1, "CNAME", verifyInfo.CnameValidationP2)
|
zr, err := iss.CNAMEValidation.createRecord(ctx, verifyInfo.CnameValidationP1, "CNAME", verifyInfo.CnameValidationP2+".") // see issue #304
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, fmt.Errorf("creating CNAME record: %v", err)
|
return nil, fmt.Errorf("creating CNAME record: %v", err)
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user